Skip to content

fix(app): avoid shortcut settings flash#35349

Open
opencode-agent[bot] wants to merge 1 commit into
devfrom
settings-flash-fix
Open

fix(app): avoid shortcut settings flash#35349
opencode-agent[bot] wants to merge 1 commit into
devfrom
settings-flash-fix

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • load the visible Shortcuts settings controls with the already code-split settings dialog
  • avoid the cold-tab intermediate frame where General unmounts before the Shortcuts controls resolve

Root cause

The settings dialog is already dynamically imported, but the visible controls inside the Shortcuts tab added another lazy-loading boundary. On the first tab switch, Kobalte unmounted General before the button, search input, and list components resolved, producing an underpainted frame.

Validation

  • bun typecheck (packages/app)
  • Prettier check for settings-keybinds.tsx
  • Playwright at 1280×800 using the real app UI with mocked backend data
  • Synchronized before/after video

Comparison

  • before: b44bc0ad0740afe80beae0a1981c2c4d96f67173
  • after: e2a162db441f47e5cc55d2cbc3b98671fd3999e2

@opencode-agent opencode-agent Bot assigned Brendonovich and unassigned jayair Jul 4, 2026
@opencode-agent opencode-agent Bot marked this pull request as ready for review July 4, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants